remove stupid abstraction

src/frontend/KaizenGui.cpp

@@ -1,8 +1,8 @@
 #include <KaizenGui.hpp>
 #include <nfd.hpp>
 #include <backend/Core.hpp>
-#include <ImGuiImpl/StatusBar.hpp>
 #include <ImGuiImpl/GUI.hpp>
+#include <ImGuiImpl/StatusBar.hpp>
 #include <resources/gamecontrollerdb.h>
 
 KaizenGui::KaizenGui() noexcept : window("Kaizen", 800, 600), core(std::make_shared<n64::Core>()), vulkanWidget(core, window.getHandle()), emuThread(core, fpsCounter, vulkanWidget, settingsWindow) {  
@@ -10,82 +10,6 @@ KaizenGui::KaizenGui() noexcept : window("Kaizen", 800, 600), core(std::make_sha
   SDL_InitSubSystem(SDL_INIT_GAMEPAD);
 
   SDL_AddGamepadMapping(gamecontrollerdb_str);
-  
-  actionPause.setFunc([&]() {
-    if(ImGui::IsItemClicked()) {
-      actionPause.setLabel(actionPause.getLabel() == "Pause" ? "Resume" : "Pause");
-      core->TogglePause();
-    }
-  });
-
-  actionStop.setFunc([&]() {
-    if(ImGui::IsItemClicked()) {
-      actionStop.setEnabled(false);
-      actionPause.setEnabled(false);
-      actionReset.setEnabled(false);
-      core->Stop();
-    }
-  });
-  
-  about.setFunc([&]() {
-    ImGui::Text("Kaizen is a Nintendo 64 emulator that strives");
-    ImGui::Text("to offer a friendly user experience and compatibility.");
-    ImGui::Text("Kaizen is licensed under the BSD 3-clause license.");
-    ImGui::Text("Nintendo 64 is a registered trademark of Nintendo Co., Ltd.");
-    if(ImGui::Button("OK")) {
-      about.setOpened(false);
-      ImGui::CloseCurrentPopup();
-    }
-  });
-
-  statusBar.setFunc([&]() {
-    /* TODO: for when I'll separate the GUI and the Core in two threads again
-    ImGui::Text("GUI FPS: %.2f, Emulation FPS: %s", ImGui::GetIO().Framerate,
-      fmt::format(fpsCounter > 0 ? fmt::runtime("{0:.2f}") : fmt::runtime("{1}"), fpsCounter, "Not playing").c_str());
-    */
-    ImGui::Text("FPS: %.2f", ImGui::GetIO().Framerate);
-  });
-  
-  menuBar.addMenu({"File", 
-    {
-      {"Open", [&]() {
-        NFD::Guard guard;
-        NFD::UniquePath path;
-        static const std::vector<nfdfilteritem_t> filterItems = {
-          {"Nintendo 64 rom archive", "rar,RAR,tar,TAR,zip,ZIP,7z,7Z"},
-          {"Nintendo 64 rom", "n64,z64,v64,N64,Z64,V64"}
-        };
-
-        auto result = NFD::OpenDialog(path, filterItems.data(), filterItems.size());
-        if(result == NFD_CANCEL) return;
-        if(result == NFD_ERROR)
-          Util::panic("Error: {}", NFD::GetError());
-        
-        LoadROM(path.get());
-      }},
-      {"Exit", [&]() {
-        quit = true;
-        emuThread.Stop();
-      }}
-    }
-  });
-
-  menuBar.addMenu({
-    "Emulation", {
-    actionPause,
-    actionStop,
-    actionReset,
-    {"Settings", [&]() {
-      settingsWindow.popup.setOpened(true);
-    }},
-  }});
-
-  menuBar.addMenu({
-    "Help", {
-    {"About", [&]() {
-      about.setOpened(true);
-    }},
-  }});
 }
 
 KaizenGui::~KaizenGui() {
@@ -190,10 +114,85 @@ void KaizenGui::HandleInput(SDL_Event event) {
 
 void KaizenGui::RenderUI() {
   gui::StartFrame();
-  statusBar.render();
-  menuBar.render();
-  settingsWindow.render();
-  about.render();
+
+  static bool actionsEnabled = false;
+
+  if(ImGui::BeginMainMenuBar()) {
+    if(ImGui::BeginMenu("File")) {
+      if(ImGui::MenuItem("Open")) {
+        NFD::Guard guard;
+        NFD::UniquePath path;
+        static const std::vector<nfdfilteritem_t> filterItems = {
+          {"Nintendo 64 rom archive", "rar,RAR,tar,TAR,zip,ZIP,7z,7Z"},
+          {"Nintendo 64 rom", "n64,z64,v64,N64,Z64,V64"}
+        };
+
+        auto result = NFD::OpenDialog(path, filterItems.data(), filterItems.size());
+        if(result == NFD_ERROR)
+          Util::panic("Error: {}", NFD::GetError());
+        
+        if(result != NFD_CANCEL) {
+          LoadROM(path.get());
+          actionsEnabled = true;
+        }
+      }
+      if(ImGui::MenuItem("Exit")) {
+        quit = true;
+        emuThread.Stop();
+      }
+      ImGui::EndMenu();
+    }
+    if(ImGui::BeginMenu("Emulation")) {
+      ImGui::BeginDisabled(!actionsEnabled);
+      
+      if(ImGui::MenuItem(core->pause ? "Resume" : "Pause")) {
+        emuThread.TogglePause();
+      }
+      
+      if(ImGui::MenuItem("Reset")) {
+        emuThread.Reset();
+      }
+      
+      if(ImGui::MenuItem("Stop")) {
+        emuThread.Stop();
+        actionsEnabled = false;
+      }
+      
+      ImGui::EndDisabled();
+
+      if(ImGui::MenuItem("Settings")) {
+        settingsWindow.render();
+      }
+      ImGui::EndMenu();
+    }
+    if(ImGui::BeginMenu("Help")) {
+      if(ImGui::MenuItem("About")) {
+        ImGui::OpenPopup("About Kaizen");
+        ImVec2 center = ImGui::GetMainViewport()->GetCenter();
+        ImGui::SetNextWindowPos(center, ImGuiCond_Appearing, ImVec2(0.5f, 0.5f));
+
+        if (ImGui::BeginPopupModal("About Kaizen", nullptr, ImGuiWindowFlags_AlwaysAutoResize)) {
+          ImGui::Text("Kaizen is a Nintendo 64 emulator that strives");
+          ImGui::Text("to offer a friendly user experience and compatibility.");
+          ImGui::Text("Kaizen is licensed under the BSD 3-clause license.");
+          ImGui::Text("Nintendo 64 is a registered trademark of Nintendo Co., Ltd.");
+          if(ImGui::Button("OK")) {
+            ImGui::CloseCurrentPopup();
+          }
+          
+          ImGui::EndPopup();
+        }
+      }
+      
+      ImGui::EndMenu();
+    }
+    ImGui::EndMainMenuBar();
+  }
+  if(ImGui::BeginMainStatusBar()) {
+    ImGui::Text("FPS: %.2f", ImGui::GetIO().Framerate);
+    ImGui::EndMainStatusBar();
+  }
+
   ImGui::Render();
   if (ImGui::GetIO().ConfigFlags & ImGuiConfigFlags_ViewportsEnable){
     ImGui::UpdatePlatformWindows();
@@ -209,9 +208,6 @@ void KaizenGui::RenderUI() {
 }
 
 void KaizenGui::LoadROM(const std::string &path) noexcept {
-  actionPause.setEnabled(true);
-  actionReset.setEnabled(true);
-  actionStop.setEnabled(true);
   emuThread.core->LoadROM(path);
   const auto gameNameDB = emuThread.core->cpu->GetMem().rom.gameNameDB;
   Util::RPC::GetInstance().Update(Util::RPC::Playing, gameNameDB);