Minor nitpicks and smaller perf improvements (barely noticeable)
This commit is contained in:
@@ -3,29 +3,29 @@
|
||||
|
||||
namespace n64 {
|
||||
void GameDB::match(Mem &mem) {
|
||||
ROM &rom = mem.rom;
|
||||
for (const auto &i : gamedb) {
|
||||
bool matches_code = i.code == rom.code;
|
||||
const ROM &rom = mem.rom;
|
||||
for (const auto &[code, regions, saveType, name] : gamedb) {
|
||||
const bool matches_code = code == rom.code;
|
||||
bool matches_region = false;
|
||||
|
||||
for (int j = 0; j < i.regions.size() && !matches_region; j++) {
|
||||
if (i.regions[j] == rom.header.countryCode[0]) {
|
||||
for (int j = 0; j < regions.size() && !matches_region; j++) {
|
||||
if (regions[j] == rom.header.countryCode[0]) {
|
||||
matches_region = true;
|
||||
}
|
||||
}
|
||||
|
||||
if (matches_code) {
|
||||
if (matches_region) {
|
||||
mem.saveType = i.saveType;
|
||||
mem.rom.gameNameDB = i.name;
|
||||
mem.saveType = saveType;
|
||||
mem.rom.gameNameDB = name;
|
||||
return;
|
||||
}
|
||||
|
||||
Util::warn(
|
||||
"Matched code for {}, but not region! Game supposedly exists in regions [{}] but this image has region {}",
|
||||
i.name, i.regions, rom.header.countryCode[0]);
|
||||
mem.saveType = i.saveType;
|
||||
mem.rom.gameNameDB = i.name;
|
||||
name, regions, rom.header.countryCode[0]);
|
||||
mem.saveType = saveType;
|
||||
mem.rom.gameNameDB = name;
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user